
STV Swift Package
#1
Posted 26 October 2019 - 02:46 AM
- ozie likes this
#2
Posted 12 November 2019 - 07:53 AM
Hello again everyone,
I made my STV Swift Package public if any one is interested:
https://github.com/daveguerin/STV
As well as the changes I listed above, the following has also changed:
* Now using iOS 13 labelColor with a fallback for earlier iOS.
The documentation has also been update slightly:
https://daveguerin.github.io/STV/
and there's a new Docset Feed:
https://daveguerin.g...docsets/STV.xml
All comments welcome!
- halldorg likes this
#3
Posted 14 January 2020 - 12:05 AM
Hi Dave!
I recently had to update one of my older apps (that used STV) and all hell broke lose with iOS 13.
I really appreciate the work you put into this and will check it out during the coming weeks, will report back.
All the best,
Gerald
- Dave Guerin likes this
#4
Posted 14 January 2020 - 04:57 AM
Hi Gerald,
I hope it works for you, let me know if it doesn't and I'll see what I can do.
Documentation has moved to here: https://daveguerin.g...VDocumentation/
Docset feed has moved to here: https://daveguerin.g...docsets/STV.xml
- designwerks likes this
#5
Posted 24 April 2020 - 06:37 PM
Hi Dave,
I am about to try my first project using the Swift Version... I have used STV in Objective-C very successfully in a number of my apps, but want to try one in Swift Language.
I have followed all your steps to load and all is working well. Thank you for very clear instructions.
One question - Is there a simple example project in Swift, like there was in Objective-C, so I can review necessary code to insert...
Thanks,
John
#6
Posted 25 April 2020 - 02:14 AM
Hi John,
I'm glad you found it easy following my instructions. You never know if you've missed something until someone else gives it a go!
Example project are on my TODO list. I'm not at all conversant with Swift unfortunately, so my examples would probably be the Objective C examples updated to use the Swift Package version of STV.
@wizgod is probably the man for Swift examples, or if you get it working maybe you could convert some of the current examples to Swift.
I'm thinking maybe examples should be in a separate STVExamples repository.
Some of my changes to avoid crashes/warnings in iOS 13 I need to look at again as I think some of them aren't very efficient when it comes to cell reuse.
Let us know how you get on with the STV SPM and Swift!
Cheers,
Dave
#7
Posted 14 May 2020 - 01:53 AM
Hi Dave!
As promised, my report on how the upgrade to your version went. I actually planned to do this during summer, but a bug forced my hand and I had to do it today.
So far it only took me about an hour, and preliminary testing suggests that all went well and without hiccup.
About the only thing I had to adjust were the modalPresentationStyles on my PopOvers, which now need to be set to fullScreen if you don't want Apple's swipe down to close functionality.
I'm chuffed with the results and can't thank you enough for your work!
All the best,
Gerald
#8
Posted 18 May 2020 - 08:48 AM
Hi Gerald,
Thanks for letting me know how it went. I glad you got it all working without too much trouble.
I think the modalPresentationStyles are an iOS thing and not an STV but if that's all you had to change then great!
I should return to have a better look at the STV SCTableViewModel methods -live, -cellAtIndexPath:, and -tableView:shouldIndentWhileEditingRowAtIndexPath: at some point. My fix for the iOS 13 error/warning has made STV less efficient, I think STV is now creating some cells repeatedly for the same index. They are all dealloc when they are done with, but a cell at an index should only be created the once. I'll take a look sometime soon (ish)!
Cheers,
Dave
#9
Posted 27 May 2020 - 04:49 AM
Hi Dave,
i just noticed something that, I think, hasn't happened before. When I select some rows they behave as if the background-color of the labels is fixed and cannot change to the default selected-color. Have you seen anything like this before?
I checked that If I change the background color of the labels in willDisplay blocks I can set them to [UIColor clearColor] for example to fix it for some labels, but changing them all would be a pain. Any idea why this could happen?
Thanks,
Gerald
Attached Files
#10
Posted 29 May 2020 - 12:10 AM
Hi Gerald,
I _think_ this is an iOS 13 thing, previously the default background colour of a label in a cell was white, as that was the default background colour of a cell.
To accommodate Dark Mode I think the default has now change to clear.
I _think_.
Cheers,
Dave
Edited by Dave Guerin, 29 May 2020 - 12:11 AM.
0 user(s) are reading this topic
0 members, 0 guests, 0 anonymous users